[PATCH] comments: display username and name instead of only username

[Mads Kiilerich]

On 04/18/2015 04:12 PM, Thomas De Schampheleire wrote:
> # HG changeset patch
> # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> # Date 1429285875 -7200
> #      Fri Apr 17 17:51:15 2015 +0200
> # Node ID a7cc66bf51ec89134cb7b02aca044bb74a56f768
> # Parent  e721e300d713a00747e6c519a98b38ef931b0f40
> comments: display username and name instead of only username
>
> The full name is more significant to many people than a username.

That is probably very reasonable. I will review in more details later.

It would be an even more compelling argument if we could argue that it 
also is making the UI more consistent. I guess we should have some 
guidelines and/or macros ...

/Mads

>
> diff --git a/kallithea/templates/changeset/changeset_file_comment.html b/kallithea/templates/changeset/changeset_file_comment.html
> --- a/kallithea/templates/changeset/changeset_file_comment.html
> +++ b/kallithea/templates/changeset/changeset_file_comment.html
> @@ -11,7 +11,7 @@
>                  ${h.gravatar(co.author.email, size=20)}
>             </div>
>             <div class="user">
> -              ${co.author.username}
> +              ${co.author.username_and_name}
>             </div>
>             <div class="date">
>                 ${h.age(co.modified_at)}