[PATCH] comments: display username and name instead of only username

Thomas De Schampheleire patrickdepinguin at gmail.com
Sun Apr 19 05:57:10 EDT 2015

On Sun, Apr 19, 2015 at 12:26 AM, Mads Kiilerich <mads at kiilerich.com> wrote:
> On 04/18/2015 04:12 PM, Thomas De Schampheleire wrote:
>> # HG changeset patch
>> # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>> # Date 1429285875 -7200
>> #      Fri Apr 17 17:51:15 2015 +0200
>> # Node ID a7cc66bf51ec89134cb7b02aca044bb74a56f768
>> # Parent  e721e300d713a00747e6c519a98b38ef931b0f40
>> comments: display username and name instead of only username
>> The full name is more significant to many people than a username.
> That is probably very reasonable. I will review in more details later.
> It would be an even more compelling argument if we could argue that it also
> is making the UI more consistent. I guess we should have some guidelines
> and/or macros ...

Yes, agreed.

My opinion is that a username is typically not relevant to other
developers, while the full name is. People are not trained to remember
each other's username. The username is only needed for @mentions, and
could be useful when adding reviewers in a pull request.

On the other hand, one could be concerned about two different users
with the same name, for example Marc Johnson. With this in mind,
additionally showing the username would differentiate between them.

Originally my preference would have been to only show the full name
except in some cases, but it may be more consistent (and fix the
ambiguity for two people with the same name) to always show the name

Full Name (username)

What do you think?


More information about the kallithea-general mailing list