[PATCH 0 of 2] new commits push notification -- incomplete and not really working

Ronny Pfannschmidt opensource at ronnypfannschmidt.de
Sun Apr 19 02:14:26 EDT 2015

I think using web API calls from hooks might be a good idea

Am 19. April 2015 06:56:07 MESZ, schrieb Mads Kiilerich <mads at kiilerich.com>:
>On 04/18/2015 03:54 PM, Andrew Shadura wrote:
>> Hello everyone,
>> During the last few days I've been trying to develop a patch to
>> email notifications about incoming commits.
>> The final version of the patch working locally is here, but:
>>   i) it's hardcoded for one email address, i.e. it doesn't have any
>>   ii) when I tried to use in on Our Own Kallithea, it broke the whole
>>       presumably in the config initialisation code.
>> Anyway, I decided to post it here so you comment and maybe fix it :)
>That seems complex. It is impressive you (almost) made it work. But it 
>also seems to suggest that it not is the best approach.
>How about some other approaches:
>* letting the hook collect all the info seems unfortunate; pass enough 
>parameters when configuring the hook for the vcs and let the hook be 
>more self contained
>* doing it in the same process seems unfortunate; implement a paster 
>command that the hook can call
>* not having this info available in the environment for vcs commands 
>seems wrong; reorder the wsgi middleware so it also gets defined for
>All the options seems to have disadvantages ... but one of them might
>better ...
>kallithea-general mailing list
>kallithea-general at sfconservancy.org

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20150419/db378965/attachment.html>

More information about the kallithea-general mailing list