[PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

Jan Heylen heyleke at gmail.com
Tue Jun 16 15:49:31 EDT 2015


On Tue, Jun 16, 2015 at 9:21 PM, Thomas De Schampheleire
<patrickdepinguin at gmail.com> wrote:
> On Tue, Jun 16, 2015 at 8:31 PM, Jan Heylen <heyleke at gmail.com> wrote:
>> # HG changeset patch
>> # User Jan Heylen <heyleke at gmail.com>
>> # Date 1434479490 -7200
>> #      Tue Jun 16 20:31:30 2015 +0200
>> # Node ID 3ff99546a950144258be3078b4483e7cebd5d720
>> # Parent  53d68f201e4602d3f2ccfcd27107d2ebea2deea2
>> backout "pullrequests: don't add automatic 'status change' message - it will be added in template"
>>
>> this commit causes following simple test to fail:
>> * start from empty database with 2 repos, one a fork of the other, 1 commit diff
>> * create a new pull request with that one commit
>> * after the pull request is created, immediatly click on the link to the commit
>>   in the pull request content list
>> --> error with undefined comments variable
>>
>
> Please specify the commit number (14d75d4b03cd or in full
> 14d75d4b03cd52c2ec6fe2cde26a6cbe5095d7cf) when referencing other
> commits: it's so much easier to look up.
>
> Best regards,
> Thomas

True, my mistake, but I had a feeling this patch wasn't going to be
accepted as-is anyway ;-)

J.


More information about the kallithea-general mailing list