[PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

[Mads Kiilerich]

On 06/16/2015 08:31 PM, Jan Heylen wrote:
> # HG changeset patch
> # User Jan Heylen <heyleke at gmail.com>
> # Date 1434479490 -7200
> #      Tue Jun 16 20:31:30 2015 +0200
> # Node ID 3ff99546a950144258be3078b4483e7cebd5d720
> # Parent  53d68f201e4602d3f2ccfcd27107d2ebea2deea2
> backout "pullrequests: don't add automatic 'status change' message - it will be added in template"
>
> this commit causes following simple test to fail:
> * start from empty database with 2 repos, one a fork of the other, 1 commit diff
> * create a new pull request with that one commit
> * after the pull request is created, immediatly click on the link to the commit
>    in the pull request content list
> --> error with undefined comments variable

I cannot reproduce the problem.

Exactly which URL are you clicking?
Exactly what error do you get?
I assume you get a stack trace on the server - which one?

/Mads

>
> diff -r 53d68f201e46 -r 3ff99546a950 kallithea/model/pull_request.py
> --- a/kallithea/model/pull_request.py	Mon Jun 08 06:46:48 2015 +0200
> +++ b/kallithea/model/pull_request.py	Tue Jun 16 20:31:30 2015 +0200
> @@ -93,7 +93,7 @@
>           #reset state to under-review
>           from kallithea.model.comment import ChangesetCommentsModel
>           comment = ChangesetCommentsModel().create(
> -            text=u'',
> +            text=u'Auto status change to %s' % (ChangesetStatus.get_status_lbl(ChangesetStatus.STATUS_UNDER_REVIEW)),
>               repo=org_repo,
>               user=new.author,
>               pull_request=new,
> _______________________________________________
> kallithea-general mailing list
> kallithea-general at sfconservancy.org
> http://lists.sfconservancy.org/mailman/listinfo/kallithea-general