[PATCH 1 of 2] pullrequest: warn for duplication of reviewer handling with base.js
Thomas De Schampheleire
patrickdepinguin at gmail.com
Sat Jun 20 15:29:43 EDT 2015
# HG changeset patch
# User Thomas De Schampheleire <thomas.de_schampheleire at alcatel-lucent.com>
# Date 1434721227 -7200
# Fri Jun 19 15:40:27 2015 +0200
# Node ID ea284e51ec2eb80cbf3d3552798b9a060d1746b1
# Parent a7ac467edbf5b71b4198f3e0e6b543c3fbb8cc47
pullrequest: warn for duplication of reviewer handling with base.js
diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js
--- a/kallithea/public/js/base.js
+++ b/kallithea/public/js/base.js
@@ -1473,6 +1473,9 @@ var addReviewMember = function(id,fname,
var gravatarelm = '<img alt="gravatar" style="width: {0}px; height: {0}px" src="{1}"/>'.format(gravatar_size, gravatar_link);
if (!gravatar_link)
gravatarelm = '<i class="icon-user" style="font-size: {0}px;"></i>'.format(gravatar_size);
+ // WARNING: the HTML below is duplicate with
+ // kallithea/templates/pullrequests/pullrequest_show.html
+ // If you change something here it should be reflected in the template too.
var element = (
' <li id="reviewer_{2}">\n'+
' <div class="reviewers_member">\n'+
diff --git a/kallithea/templates/pullrequests/pullrequest_show.html b/kallithea/templates/pullrequests/pullrequest_show.html
--- a/kallithea/templates/pullrequests/pullrequest_show.html
+++ b/kallithea/templates/pullrequests/pullrequest_show.html
@@ -212,6 +212,9 @@
<div>
<ul id="review_members" class="group_members">
%for member,status in c.pull_request_reviewers:
+ ## WARNING: the HTML below is duplicate with
+ ## kallithea/public/js/base.js
+ ## If you change something here it should be reflected in the template too.
<li id="reviewer_${member.user_id}">
<div class="reviewers_member">
<div class="reviewer_status tooltip" title="${h.tooltip(h.changeset_status_lbl(status.status if status else 'not_reviewed'))}">
More information about the kallithea-general
mailing list