[PATCH 2 of 2] pullrequest: when adding a reviewer, show full name only

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat Jun 20 15:29:44 EDT 2015


# HG changeset patch
# User Thomas De Schampheleire <thomas.de_schampheleire at alcatel-lucent.com>
# Date 1434721370 -7200
#      Fri Jun 19 15:42:50 2015 +0200
# Node ID 90e982b6bca805a574f6dc7f7535169d827ea3fa
# Parent  ea284e51ec2eb80cbf3d3552798b9a060d1746b1
pullrequest: when adding a reviewer, show full name only

Existing reviewers are shown with full name (Firstname Lastname) without
username. In symmetry, newly added reviewers should be displayed the same way.

diff --git a/kallithea/public/js/base.js b/kallithea/public/js/base.js
--- a/kallithea/public/js/base.js
+++ b/kallithea/public/js/base.js
@@ -1469,7 +1469,7 @@ var MentionsAutoComplete = function (div
 }
 
 var addReviewMember = function(id,fname,lname,nname,gravatar_link,gravatar_size){
-    var displayname = "{0} {1} ({2})".format(fname, lname, nname);
+    var displayname = "{0} {1}".format(fname, lname);
     var gravatarelm = '<img alt="gravatar" style="width: {0}px; height: {0}px" src="{1}"/>'.format(gravatar_size, gravatar_link);
     if (!gravatar_link)
         gravatarelm = '<i class="icon-user" style="font-size: {0}px;"></i>'.format(gravatar_size);


More information about the kallithea-general mailing list