Issue #190: Range selection from changelog fails (with git) (conservancy/kallithea)

[eivindt]

New issue 190: Range selection from changelog fails (with git)
https://bitbucket.org/conservancy/kallithea/issues/190/range-selection-from-changelog-fails-with

eivindt:


There's something wrong with range selection on the changelog page, at least for git.

Selecting ranges and then creating a pull request or "Shot selected changeset" both fail (500 or 404).

The reason is that the changelog template expliticly uses short revs for the URLs for both these buttons (using only the first 12 bytes of the revision hash).  This doesn't work for the git backend, as it compares these revs with the revision hashes retrieved using *git log -format %H* and *git rev-list* (both of which return full 40 character hashes) and fails to find the wanted changesets.

I've fixed this on my local install by using the short revision hashes only for display, and sending the full hashes in the URL, but I don't know if this is the correct solution.