[PATCH] changeset: improve the comment count information display

Mads Kiilerich mads at kiilerich.com
Tue Mar 1 12:56:50 UTC 2016


On 03/01/2016 01:39 PM, Angel Ezquerra wrote:
> On Mon, Feb 29, 2016 at 3:59 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
>> On 02/27/2016 12:24 PM, Angel Ezquerra wrote:
>>> # HG changeset patch
>>> # User Angel Ezquerra <angel.ezquerra at gmail.com>
>>> # Date 1456572240 -3600
>>> #      Sat Feb 27 12:24:00 2016 +0100
>>> # Branch stable
>>> # Node ID 58ee8a76b6a8ae0a69d3f50b2e3e3357780598c9
>>> # Parent  a13394a91f352a982afcf0b9141ece5537caacb1
>>> changeset: improve the comment count information display
>>>
>>> Some recent revisions have changed the way comments are counted. We no
>>> longer
>>> count "status change only comments" as comments on the changelog, etc.
>>
>> BTW: We also have this weird thing where a changeset seems to only have one
>> status (the most recent "vote" wins) while PRs is better at keeping
>> different "votes" apart and the overall "status" is more undefined.
>>
>> /Mads
> I haven't used PRs at all with Kallithea, so I am not sure how they
> work. Do you mean that for PRs multiple reviewers must approve before
> the whole PR is considered as approved?

There is currently no enforcement of a specific work flow. We routinely 
accept PRs that haven't been fully approved yet.

/Mads


More information about the kallithea-general mailing list