PR firstline overflow

[Mads Kiilerich]

On 02/21/2018 10:15 AM, Thomas De Schampheleire wrote:
> Hi Dominik,
>
> Just noticed a small issue on a pullrequest page in Kallithea: in the
> list of commits, the first line of the commit message may overflow to
> the right, over the labels with branch name, number of comments, etc.
> (extra_container).

I'm probably to blame for that.

I pushed a fix in 
https://kallithea-scm.org/repos/kallithea/changeset/ba8781f3f2c253ee031ba958dc6a4c0a9613a88f 
.


> Is there a particular reason for not making the extra_container an
> actual column?

How wide should that column be?

The width of the content varies a lot - just like commit messages do. 
Commit messages must be truncated anyway, so having them in the same 
column seems like a good idea.

(Now, I think it would be good to also have the "expand" button move 
from a separate column to be shown as the first label ...)

> In the screenshot, note also that the bottom line of the 'draft' label
> is not visible, because it overflows to the bottom and overflow is
> hidden on the table cells. I think that the label should be slightly
> smaller or the rows slightly higher, to fix that.

Yes, that needs a bit of tweaking across browsers. Perhaps less padding 
on the td and margins on the content. And perhaps also related to the 
positioning of avatars and checkboxes and how they influence spacing.

/Mads