[PATCH 1 of 2] pull requests: urlify title to make issue references clickable

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat Feb 23 21:05:24 UTC 2019


# HG changeset patch
# User Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
# Date 1550952266 -3600
#      Sat Feb 23 21:04:26 2019 +0100
# Node ID c88462e9513c328754d690b079d4eaf20adab49c
# Parent  75f746df73e2f1f5c34669ea8eb77bdb9b975cf9
pull requests: urlify title to make issue references clickable

Issue references and commit hashes are already clickable in:
- pull request descriptions,
- commit messages
- changelog

but not yet in:
- pull request titles
- pull request listings

This commit handles the former case.

diff --git a/kallithea/templates/pullrequests/pullrequest_show.html b/kallithea/templates/pullrequests/pullrequest_show.html
--- a/kallithea/templates/pullrequests/pullrequest_show.html
+++ b/kallithea/templates/pullrequests/pullrequest_show.html
@@ -26,7 +26,7 @@
     <div class="form pr-box pull-left">
       <div class="pr-details-title ${'closed' if c.pull_request.is_closed() else ''}">
         <h3>
-          ${_('Title')}: ${c.pull_request.title}
+          ${_('Title')}: ${h.urlify_text(c.pull_request.title, c.pull_request.org_repo.repo_name)}
           %if c.pull_request.is_closed():
               (${_('Closed')})
           %endif


More information about the kallithea-general mailing list