[PATCH 2 of 2] pull requests: urlify pull request lists to make issue references clickable

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat Feb 23 21:05:25 UTC 2019


# HG changeset patch
# User Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
# Date 1550952659 -3600
#      Sat Feb 23 21:10:59 2019 +0100
# Node ID d639b9c8a0713b0f23396c4465b75cc75c5eac65
# Parent  c88462e9513c328754d690b079d4eaf20adab49c
pull requests: urlify pull request lists to make issue references clickable

Issue references and commit hashes are already clickable in:
- pull request descriptions,
- commit messages
- changelog

but not yet in:
- pull request titles
- pull request listings

The previous commit handled the former case, this commit handles the latter.

diff --git a/kallithea/templates/pullrequests/pullrequest_data.html b/kallithea/templates/pullrequests/pullrequest_data.html
--- a/kallithea/templates/pullrequests/pullrequest_data.html
+++ b/kallithea/templates/pullrequests/pullrequest_data.html
@@ -32,7 +32,7 @@
       </td>
       <td>
         <a href="${pr.url()}">
-        ${pr.title or _("(no title)")}
+        ${h.urlify_text(pr.title or _("(no title)"), pr.org_repo.repo_name, pr.url())}
         %if pr.is_closed():
           <span class="pr-closed-tag">${_('Closed')}</span>
         %endif


More information about the kallithea-general mailing list