[PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

[Mads Kiilerich]

On 2/8/20 2:06 AM, Ross Thomas wrote:
> # HG changeset patch
> # User Ross Thomas <ross at lns-nevasoft.com>
> # Date 1581113799 28800
> #      Fri Feb 07 14:16:39 2020 -0800
> # Branch stable
> # Node ID 504adebdb50183678de362b52bc89a9c082f4ea7
> # Parent  f273a7b53fe035c12a55b6a3e34f849af245d797
> ui: Add support for extra 'quick' icons in repo browser
> config: Add new value 'repo_list_extra' to enable/disable 'quick' icons


It would be nice to have more details in the commit message explaining 
what the intent is, so we don't have to reverse engineer it. We want to 
review that we are aligned on the intent, and that the change is a 
maintainable and good / best way to implement the intent.


But it seems to implement having the plain repo listings show the 
toggling "following" heart, the "fork" icon linking to the fork form, 
and a "edit" cog - a bit like how 'Edit' is available in 
http://localhost:5000/_admin/repos .


I see the point in showing in the repo list which repos are followed. I 
don't think we have to make that configurable. It would be nice to land 
just that first.

The name "extra" is however very generic and could just as well be used 
for the next thing we add. "Actions" would perhaps be descriptive ... 
and show the.parallel to what is done in the admin repo listing.

But from another perspective: "Follow" is not about properties of the 
repo, but about how the user looks at the repo. It might thus not so 
much belong in the middle of repo properties. It should thus perhaps be 
a separate first column, shown before the repo name? (The other "extra" 
actions is a different story.)


For the remaining actions: can you say more about the use case for 
having the actions for fork and edit shown *that* visible and directly 
available? These options (and more) are already availble one click away, 
after selecting the repo. While I see the use case for making it easy to 
manage following many repos, it must be much more rare  to edit and fork 
many repos, and in each case it will require a lot of extra clicks 
anyway, and having the shortcut on the repo list will only save few a 
fraction of the work.

Also, this seems related to the story told at 
https://kallithea-scm.org/repos/kallithea/changeset/b8830c373681 and 
https://kallithea-scm.org/repos/kallithea/changeset/184c78cfded1 .


/Mads