[PATCH 2 of 2] ui: Add support for extra 'quick' icons in repo browser

[Ross Thomas]

On 2/8/20 7:10 AM, Mads Kiilerich wrote:
> It would be nice to have more details in the commit message explaining 
> what the intent is, so we don't have to reverse engineer it. We want to 
> review that we are aligned on the intent, and that the change is a 
> maintainable and good / best way to implement the intent.

Apologies.  I had meant to add this:

This adds quicker access to the most-used repo 'Options' menu functions.
 All three icons are active and function exactly as their counterparts
in the menu.

Clicking on the (Un)Follow 'heart' will toggle the caller's follow
status for that repo.

Clicking on the 'fork' will open up the 'fork repo' page for that repo.

If you are an admin for a repo the gear will appear and clicking on it
will open up the Settings page for that repo.

> I see the point in showing in the repo list which repos are followed. I 
> don't think we have to make that configurable. It would be nice to land 
> just that first.

As mentioned above, that is more than just an indicator.

> I see the point in showing in the repo list which repos are followed. I 
> don't think we have to make that configurable. It would be nice to land 
> just that first.

True.  We had additional plans for that area initially but decided on
just this so the name lost its general intent.  I can certainly rename it.

And the placement of 'follow' at the front of that extra group was
intentional in order for it to be seen first in that group and to keep
our intrusion into the table as low-impact as possible.  But, as you
say, it could be moved if it is no longer a config item.

As an aside, I do seem to have introduced a bug making the extra item
display fully configurable so I'm fixing that now.  I can add that along
with the renamed vars/items, if you think this thing is going anywhere.

> For the remaining actions: can you say more about the use case for 
> having the actions for fork and edit shown *that* visible and directly 
> available? These options (and more) are already availble one click away, 
> after selecting the repo. While I see the use case for making it easy to 
> manage following many repos, it must be much more rare  to edit and fork 
> many repos, and in each case it will require a lot of extra clicks 
> anyway, and having the shortcut on the repo list will only save few a 
> fraction of the work.

This was very definitely a case of function location and navigation.
Some were consistently confused about where the functionality resided
and some were: "Wait!  I have to make 3 clicks to do something against a
repo I can already see?"

We here all agreed that this would make things a lot easier ... for us
at least.

> Also, this seems related to the story told at 
> https://kallithea-scm.org/repos/kallithea/changeset/b8830c373681 and 
> https://kallithea-scm.org/repos/kallithea/changeset/184c78cfded1 .

Oh!  I hadn't seen those obviously.

Coincidentally, one option we considered was to do something like the
menu you had previously.  But that was too close to the existing UX
while this minimal set of immediate actions seemed like a good
compromise (again, for us).

Ross.