Kallithea 0.3.99 Default Branch verify commit

[Matey Chopov]

Hi guys,

I cloned the default branch today on our Kallithea test server and when I tried cloning a random repo from our server, I got an HTTP Error: 500 (Internal Server error) and this stack trace:

Traceback (most recent call last):
  File "/home/kallithea/kallithea-venv/lib/python2.7/site-packages/tg/support/registry.py", line 253, in __call__
    app_iter = self.application(environ, start_response)
  File "/home/kallithea/kallithea-venv/lib/python2.7/site-packages/tg/support/middlewares.py", line 135, in __call__
    return self._stream_response(self.app(environ, start_response))
  File "/home/kallithea/kallithea/kallithea/lib/base.py", line 364, in __call__
    return self._handle_request(environ, start_response)
  File "/home/kallithea/kallithea/kallithea/lib/middleware/simplegit.py", line 69, in _handle_request
    return self.application(environ, start_response)
  File "/home/kallithea/kallithea/kallithea/lib/base.py", line 364, in __call__
    return self._handle_request(environ, start_response)
  File "/home/kallithea/kallithea/kallithea/lib/middleware/simplehg.py", line 143, in _handle_request
    self._augment_hgrc(repo_path, baseui)
  File "/home/kallithea/kallithea/kallithea/lib/middleware/simplehg.py", line 229, in _augment_hgrc
    for k, v in repoui.configitems(section):
AttributeError: 'bool' object has no attribute 'configitems'

I checked the latest commits and I think the issue may be related to this one: https://kallithea-scm.org/repos/kallithea/changeset/89c30b145bb8a4151c1154c42c4e9ec23ff442f8

If I add back line 240 (if repoui: ) which was removed from simplehg.py and I keep the other changes from the commit everything works, but if I comment that line I get the 'bool' exception.

Can you confirm?

Thanks,

Mat



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20180820/a3b73148/attachment.html>